如何重构PHP函数：消除Switch语句与优化验证逻辑

protected function execute(InputInterface $input, OutputInterface $output): int
{
    $this->setDrinkType($input);

    if (in_array($this->drinkType, $this->allowedDrinkTypes)) {
        // ... 核心逻辑 ...
    }
    $output->writeln('The drink type should be tea, coffee or chocolate');
    return 0;
}

protected function execute(InputInterface $input, OutputInterface $output): int
{
    $this->setDrinkType($input);

    // 如果饮料类型不被允许，立即返回并输出错误信息
    if (!in_array($this->drinkType, $this->allowedDrinkTypes)) {
        $output->writeln('The drink type should be tea, coffee or chocolate');
        return 0; // 或者返回1表示错误
    }

    // ... 后续逻辑 ...
}

switch ($this->drinkType) {
    case 'tea':
        if ($money < 0.4) { /* ... */ }
        break;
    case 'coffee':
        if ($money < 0.5) { /* ... */ }
        break;
    case 'chocolate':
        if ($money < 0.6) { /* ... */ }
        break;
}

// 定义饮料成本映射，可以作为类成员变量或配置项
$drinkCosts = [
    'tea' => 0.4,
    'coffee' => 0.5,
    'chocolate' => 0.6
];

$money = $input->getArgument('money');

// 从映射中获取当前饮料的成本
$drinkCost = $drinkCosts[$this->drinkType];
if ($money < $drinkCost) {
    $output->writeln('The ' . $this->drinkType . ' costs ' . $drinkCost);
    return 0; // 或者返回1表示错误
}

if ($this->hasCorrectSugars($input)) {
    $this->checkSugars($input, $output);
    return 0;
}
$output->writeln('The number of sugars should be between 0 and 2');
return 0;

// 如果糖量不正确，立即返回并输出错误信息
if (!$this->hasCorrectSugars($input)) {
    $output->writeln('The number of sugars should be between 0 and 2');
    return 0; // 或者返回1表示错误
}

// 糖量正确，则调用checkSugars进行信息输出
$this->checkSugars($input, $output);
return 0; // 如果是成功完成，返回0

protected function hasCorrectSugars($input): bool
{
    $sugars = $input->getArgument('sugars');
    // 假设 $this->minSugars 和 $this->maxSugars 已定义
    return ($sugars >= $this->minSugars && $sugars <= $this->maxSugars);
}

protected function checkSugars($input, $output): void
{
    $sugars = $input->getArgument('sugars');

    $output->write('You have ordered a ' . $this->drinkType);
    $this->isExtraHot($input, $output); // 假设此函数存在并处理额外热度信息
    $output->write(' with ' . $sugars . ' sugars');
    if ($sugars > 0) {
        $output->write(' (stick included)');
    }
    $output->writeln('');
}

use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

// 假设这是一个Command类的一部分
class DrinkOrderCommand
{
    protected string $drinkType;
    protected array $allowedDrinkTypes = ['tea', 'coffee', 'chocolate'];
    protected float $minSugars = 0;
    protected float $maxSugars = 2;

    // 假设 setDrinkType 和 isExtraHot 等方法已定义
    protected function setDrinkType(InputInterface $input): void
    {
        $this->drinkType = $input->getArgument('drinkType'); // 假设有drinkType参数
    }

    protected function isExtraHot(InputInterface $input, OutputInterface $output): void
    {
        // 示例：根据输入判断是否额外加热并输出
        if ($input->getOption('extra-hot')) { // 假设有extra-hot选项
            $output->write(' (extra hot)');
        }
    }

    protected function hasCorrectSugars(InputInterface $input): bool
    {
        $sugars = $input->getArgument('sugars');
        return ($sugars >= $this->minSugars && $sugars <= $this->maxSugars);
    }

    protected function checkSugars(InputInterface $input, OutputInterface $output): void
    {
        $sugars = $input->getArgument('sugars');

        $output->write('You have ordered a ' . $this->drinkType);
        $this->isExtraHot($input, $output);
        $output->write(' with ' . $sugars . ' sugars');
        if ($sugars > 0) {
            $output->write(' (stick included)');
        }
        $output->writeln('');
    }

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $this->setDrinkType($input);

        // 1. 卫语句：验证饮料类型
        if (!in_array($this->drinkType, $this->allowedDrinkTypes)) {
            $output->writeln('The drink type should be tea, coffee or chocolate');
            return 1; // 错误返回非0
        }

        // 2. 使用映射替代switch：验证金额
        $drinkCosts = [
            'tea' => 0.4,
            'coffee' => 0.5,
            'chocolate' => 0.6
        ];

        $money = (float)$input->getArgument('money'); // 确保金额是浮点数

        // 检查是否存在该饮料类型的成本，虽然in_array已检查，但这里更严谨
        if (!isset($drinkCosts[$this->drinkType])) {
             $output->writeln('Error: Unknown drink type cost configuration.');
             return 1;
        }

        $drinkCost = $drinkCosts[$this->drinkType];
        if ($money < $drinkCost) {
            $output->writeln('The ' . $this->drinkType . ' costs ' . $drinkCost);
            return 1; // 错误返回非0
        }

        // 3. 卫语句：验证糖量
        if (!$this->hasCorrectSugars($input)) {
            $output->writeln('The number of sugars should be between 0 and 2');
            return 1; // 错误返回非0
        }

        // 4. 执行成功后的输出逻辑
        $this->checkSugars($input, $output);

        return 0; // 成功返回0
    }
}